feat: add bulk Telegram campaigns #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…positional argument to options object
- Add bulk processing support to sendTelegram method - Support ProcessBulkRequestResponse with tasks array - Add prepareBulkRequest integration with dataprotector SDK - Update types to support bulk orders and responses - Add unit tests for bulk processing scenarios - Add e2e test for bulk telegram sending - Update IExecWeb3telegram to use dataprotector instance - Fix IPFS config to use ipfsGatewayURL and ipfsNodeURL - Handle union types (SendTelegramSingleResponse | ProcessBulkRequestResponse) - Add tests for bulk operations with allowBulk access grants
- Change iexec from 8.20.0-feat-bulk-processing-62e7c5f to exact version - Update package-lock.json with resolved dependencies - Clean up nested dependencies structure
- Remove PrepareBulkRequestResponse import (no longer needed) - Replace bulkRequest with grantedAccess array parameter - Make protectedData optional (required only for single processing) - Add maxProtectedDataPerTask parameter - Update SendTelegramParams documentation
- Add bulkOnly optional parameter to filter contacts with bulk access - Pass bulkOnly parameter to fetchDatasetOrderbook calls - Support filtering orders by bulk access capability - Default value is false (returns all contacts)
…equest - Replace bulkRequest parameter with grantedAccess array - Make protectedData optional (required only for single processing mode) - Restructure logic: bulk processing vs single processing - Call prepareBulkRequest before processBulkRequest when grantedAccess provided - Move protectedData validation to single processing mode only - Improve separation of concerns between bulk and single processing
- Replace bulkRequest with grantedAccess parameter - Remove unused prepareBulkRequest call (now internal to sendTelegram) - Add maxProtectedDataPerTask parameter - Make protectedData optional in test call
…o sdk-publish-npm.yml
- Update @iexec/dataprotector from 2.0.0-beta.20-feat to ^2.0.0-beta.21 - Update iexec from 8.20.0-feat to ^8.22.0
- Replace bulkOrders with bulkAccesses in prepareBulkRequest calls - Add ProcessBulkRequestParams type argument to ProcessBulkRequestResponse - Fix e2e test to handle expected error when bulk processing is not available on network
abbesBenayache
force-pushed
the
feat/sdk-bulk-processing-support
branch
from
b2f74b7 to
4f3512b
Compare
- Updated createAndPublishAppOrders to resolve ENS names before creating app orders - Fixes 'Invalid order signer, must be the resource owner' error in e2e tests - Ensures app orders are created with the correct resolved address
- Updated sendTelegram to properly handle protocol errors by checking isProtocolError flag before creating new WorkflowError - Fixed test to use Web3TelegramWorkflowError instead of WorkflowError from @iexec/dataprotector - Ensures protocol errors are properly detected and re-thrown with isProtocolError flag set
Comment on lines
+72
to
+74
| const isProcessProtectedDataError = | ||
| error instanceof Error && | ||
| error.message === 'Failed to process protected data'; |
Member
There was a problem hiding this comment.
Do not rely on the error message
import { WorkflowError as DPWorkflowError } from '@iexec/dataprotector"
// ...
const isProcessProtectedDataError =
error instanceof DPWorkflowError;
Comment on lines
+56
to
+58
| if ((error as any)?.isProtocolError === true) { | ||
| throw error; | ||
| } |
Member
There was a problem hiding this comment.
What is the purpose of this code? I can't figure out when this happens.
Comment on lines
+389
to
+427
| it('should re-throw protocol errors without modification', async () => { | ||
| // --- GIVEN | ||
| const mockCampaignRequest: BulkRequest = { | ||
| app: '0x0000000000000000000000000000000000000000', | ||
| appmaxprice: '1000', | ||
| workerpool: '0x0000000000000000000000000000000000000000', | ||
| workerpoolmaxprice: '1000', | ||
| dataset: '0x0000000000000000000000000000000000000000', | ||
| datasetmaxprice: '0', | ||
| params: '{"bulk_cid":"QmV8mtkG5qjAYjMGGkm6AKdXoXSZxfi1Wqbem4uX4oi9QM"}', | ||
| requester: getRandomAddress().toLowerCase(), | ||
| beneficiary: getRandomAddress().toLowerCase(), | ||
| callback: '0x0000000000000000000000000000000000000000', | ||
| category: '0', | ||
| volume: '1', | ||
| tag: '0x0000000000000000000000000000000000000000000000000000000000000000', | ||
| trust: '0', | ||
| salt: '0x0000000000000000000000000000000000000000000000000000000000000000', | ||
| sign: '0x0000000000000000000000000000000000000000000000000000000000000000', | ||
| }; | ||
|
|
||
| const protocolError = new Error('Protocol error'); | ||
| (protocolError as any).isProtocolError = true; | ||
|
|
||
| const mockDataprotector = { | ||
| processBulkRequest: jest | ||
| .fn<() => Promise<any>>() | ||
| .mockRejectedValue(protocolError), | ||
| } as any; | ||
|
|
||
| // --- WHEN & THEN | ||
| await expect( | ||
| sendTelegramCampaign({ | ||
| dataProtector: mockDataprotector, | ||
| workerpoolAddressOrEns: defaultConfig.prodWorkerpoolAddress, | ||
| campaignRequest: mockCampaignRequest, | ||
| }) | ||
| ).rejects.toBe(protocolError); | ||
| }); |
Member
There was a problem hiding this comment.
I don't understand this test
PierreJeanjacquot
changed the title
PierreJeanjacquot
changed the title
PierreJeanjacquot
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.